fix: safely remove helpers in vDistanceTo and vLightHelper directives

Tresjs · Feb 5, 2025 · c505179 · c505179
1 parent a75af34
commit c505179
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/directives/vDistanceTo.ts b/src/directives/vDistanceTo.ts
@@ -33,6 +33,8 @@ export const vDistanceTo = {
   },
   unmounted: (el: TresObject) => {
     arrowHelper?.dispose()
-    el.parent.remove(arrowHelper)
+    if (el.parent) {
+      el.parent.remove(arrowHelper)
+    }
   },
 }
diff --git a/src/directives/vLightHelper.ts b/src/directives/vLightHelper.ts
@@ -56,6 +56,8 @@ export const vLightHelper = {
     if (currentInstance && currentInstance.dispose) {
       currentInstance.dispose()
     }
-    el.parent.remove(currentInstance)
+    if (el.parent) {
+      el.parent.remove(currentInstance)
+    }
   },
 }