C2PA v2.1 Updates - BMFF hash v3 assertion #213
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The BMFF hashing is quite complicated, so it would be crucial to get some sort of testing for this, covering:
|
cyraxx
reviewed
Jan 16, 2025
|
|
||
| if (!mdatBox) { | ||
| throw new ValidationError(ValidationStatusCode.AssertionBMFFHashMismatch, this.sourceBox, 'mdat not found'); | ||
| } | ||
|
|
||
| // Start from the data portion of mdat (after 8-byte header) | ||
| const dataOffset = mdatBox.offset + 8; |
There was a problem hiding this comment.
Should be able to use mdatBox.payloadOffset for this
…ertion improvements
…on logic Add unit tests
…-v3.heic' in asset-reading tests.
karlobencic
force-pushed
the
feature/bmff-hash-v3-assertion
branch
from
0733b3d to
acd6838
Compare
…handling and validation logic - Simplified exclusion sorting in AssertionUtils to only consider start positions. - Enhanced data processing in AssertionUtils to correctly handle offset markers and remaining data. - Updated BMFFHashAssertion to use mdatBox.payloadOffset for data retrieval, ensuring compliance with specifications. - Modified test cases to reflect changes in exclusion structure and improve validation checks for BMFF hash assertions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.