Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Table cell rowspan/colspan in API #1054

Open
wants to merge 1 commit into
base: table-col-width-in-api
Choose a base branch
from

Conversation

1cybersheep1
Copy link

@1cybersheep1 1cybersheep1 commented Sep 6, 2024

Summary:
This PR introduces support for rowspan and colspan properties in the API, laying the foundation for future cell merging functionality.

Details:

  • Added rowspan and colspan parameters to the CellContent and PartialCellContent types.
  • Integrated these parameters into nodeConversion, with default values set to 1.

Why:
Supporting rowspan and colspan is essential for enabling merged cells, which will enhance the user experience by allowing more complex and dynamic table structures.

Additional Notes:

  • This PR targets the current branch since I think it makes sense to merge them together.
  • The naming convention of the parameters (rowspan and colspan) can be adjusted based on feedback.

Fixes #972

Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Sep 6, 2024 7:37pm

Copy link

vercel bot commented Sep 6, 2024

@1cybersheep1 is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant