fix: ShadCN: inherit <a> styling for inline content #1228
+0
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, links are not styled when using ShadCN (and therefore hard to recognise). This patch makes them inherit the browser default, matching the Mantine behaviour.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@serpent213 is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
YousefED
reviewed
Nov 12, 2024
There was a problem hiding this comment.
@matthewlipski should this be added in this file or separately? If this file is meant as "Do not modify, it's copied directly from xxx", maybe mark it as such and add the change somewhere else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, links are not styled when using ShadCN (and therefore hard to recognise). This patch makes them inherit the browser default, matching the Mantine behaviour.
(Not sure this is the preferred way to fix it...)