Re-add media tagging as an option in settings

YoutubeDownloader.Core/Downloading/VideoDownloader.cs

@@ -4,7 +4,6 @@
 using System.Threading;
 using System.Threading.Tasks;
 using Gress;
-using YoutubeDownloader.Core.Downloading.Tagging;
 using YoutubeDownloader.Core.Utils;
 using YoutubeExplode;
 using YoutubeExplode.Converter;
@@ -16,7 +15,6 @@ namespace YoutubeDownloader.Core.Downloading;
 public class VideoDownloader
 {
     private readonly YoutubeClient _youtube = new(Http.Client);
-    private readonly MediaTagInjector _tagInjector = new();
 
     public async Task<IReadOnlyList<VideoDownloadOption>> GetDownloadOptionsAsync(
         VideoId videoId,
@@ -64,14 +62,5 @@ await _youtube.Videos.DownloadAsync(
             progress?.ToDoubleBased(),
             cancellationToken
         );
-
-        try
-        {
-            await _tagInjector.InjectTagsAsync(filePath, video, cancellationToken);
-        }
-        catch
-        {
-            // Not critical, ignore
-        }
     }
 }

YoutubeDownloader.Core/Downloading/Tagging/MediaFile.cs → YoutubeDownloader.Core/Tagging/MediaFile.cs

@@ -2,7 +2,7 @@
 using TagLib;
 using TagFile = TagLib.File;
 
-namespace YoutubeDownloader.Core.Downloading.Tagging;
+namespace YoutubeDownloader.Core.Tagging;
 
 internal partial class MediaFile : IDisposable
 {

YoutubeDownloader.Core/Downloading/Tagging/MediaTagInjector.cs → YoutubeDownloader.Core/Tagging/MediaTagInjector.cs

@@ -6,9 +6,9 @@
 using YoutubeDownloader.Core.Utils.Extensions;
 using YoutubeExplode.Videos;
 
-namespace YoutubeDownloader.Core.Downloading.Tagging;
+namespace YoutubeDownloader.Core.Tagging;
 
-internal class MediaTagInjector
+public class MediaTagInjector
 {
     private readonly MusicBrainzClient _musicBrainz = new();
 

YoutubeDownloader.Core/Downloading/Tagging/MusicBrainzClient.cs → YoutubeDownloader.Core/Tagging/MusicBrainzClient.cs

@@ -6,9 +6,8 @@
 using JsonExtensions.Http;
 using JsonExtensions.Reading;
 using YoutubeDownloader.Core.Utils;
-using YoutubeDownloader.Core.Utils.Extensions;
 
-namespace YoutubeDownloader.Core.Downloading.Tagging;
+namespace YoutubeDownloader.Core.Tagging;
 
 internal class MusicBrainzClient
 {

YoutubeDownloader.Core/Downloading/Tagging/MusicBrainzRecording.cs → YoutubeDownloader.Core/Tagging/MusicBrainzRecording.cs

@@ -1,6 +1,4 @@
-using System;
-
-namespace YoutubeDownloader.Core.Downloading.Tagging;
+namespace YoutubeDownloader.Core.Tagging;
 
 internal record MusicBrainzRecording(
     string Artist,

YoutubeDownloader/Services/SettingsService.cs

@@ -11,6 +11,8 @@ public partial class SettingsService : SettingsManager
 
     public bool IsDarkModeEnabled { get; set; } = IsDarkModeEnabledByDefault();
 
+    public bool ShouldInjectTags { get; set; } = true;
+
     public bool ShouldSkipExistingFiles { get; set; }
 
     public string FileNameTemplate { get; set; } = "$title";

YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs

@@ -7,6 +7,7 @@
 using Stylet;
 using YoutubeDownloader.Core.Downloading;
 using YoutubeDownloader.Core.Resolving;
+using YoutubeDownloader.Core.Tagging;
 using YoutubeDownloader.Services;
 using YoutubeDownloader.Utils;
 using YoutubeDownloader.ViewModels.Dialogs;
@@ -19,12 +20,14 @@ public class DashboardViewModel : PropertyChangedBase
 {
     private readonly IViewModelFactory _viewModelFactory;
     private readonly DialogManager _dialogManager;
+    private readonly SettingsService _settingsService;
 
     private readonly AutoResetProgressMuxer _progressMuxer;
     private readonly ResizableSemaphore _downloadSemaphore = new();
 
     private readonly QueryResolver _queryResolver = new();
     private readonly VideoDownloader _videoDownloader = new();
+    private readonly MediaTagInjector _mediaTagInjector = new();
 
     public bool IsBusy { get; private set; }
 
@@ -43,10 +46,11 @@ public DashboardViewModel(
     {
         _viewModelFactory = viewModelFactory;
         _dialogManager = dialogManager;
+        _settingsService = settingsService;
 
         _progressMuxer = Progress.CreateMuxer().WithAutoReset();
 
-        settingsService.BindAndInvoke(o => o.ParallelLimit, (_, e) => _downloadSemaphore.MaxCount = e.NewValue);
+        _settingsService.BindAndInvoke(o => o.ParallelLimit, (_, e) => _downloadSemaphore.MaxCount = e.NewValue);
         Progress.Bind(o => o.Current, (_, _) => NotifyOfPropertyChange(() => IsProgressIndeterminate));
     }
 
@@ -84,6 +88,22 @@ await _videoDownloader.DownloadAsync(
                     download.CancellationToken
                 );
 
+                if (_settingsService.ShouldInjectTags)
+                {
+                    try
+                    {
+                        await _mediaTagInjector.InjectTagsAsync(
+                            download.FilePath!,
+                            download.Video!,
+                            download.CancellationToken
+                        );
+                    }
+                    catch
+                    {
+                        // Media tagging is not critical
+                    }
+                }
+
                 download.Status = DownloadStatus.Completed;
             }
             catch (Exception ex)

YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs

@@ -20,6 +20,12 @@ public bool IsDarkModeEnabled
         set => _settingsService.IsDarkModeEnabled = value;
     }
 
+    public bool ShouldInjectTags
+    {
+        get => _settingsService.ShouldInjectTags;
+        set => _settingsService.ShouldInjectTags = value;
+    }
+
     public bool ShouldSkipExistingFiles
     {
         get => _settingsService.ShouldSkipExistingFiles;

YoutubeDownloader/Views/Dialogs/SettingsView.xaml

@@ -38,7 +38,7 @@
                                 <Run Text="Perform automatic updates on every launch" />
                                 <LineBreak />
                                 <Run FontWeight="SemiBold" Text="Warning:" />
-                                <Run Text="disabling this is NOT recommended because the application will stop working when integration with YouTube inevitably breaks in the future" />
+                                <Run Text="it's recommended to leave this option enabled to ensure that the app is compatible with the latest version of YouTube" />
                             </TextBlock>
                         </DockPanel.ToolTip>
                         <TextBlock
@@ -73,11 +73,26 @@
                             Unchecked="DarkModeToggleButton_Unchecked" />
                     </DockPanel>
 
+                    <!--  Inject tags  -->
+                    <DockPanel
+                        Background="Transparent"
+                        LastChildFill="False"
+                        ToolTip="Inject media tags into downloaded files">
+                        <TextBlock
+                            Margin="16,8"
+                            DockPanel.Dock="Left"
+                            Text="Inject media tags" />
+                        <ToggleButton
+                            Margin="16,8"
+                            DockPanel.Dock="Right"
+                            IsChecked="{Binding ShouldInjectTags}" />
+                    </DockPanel>
+
                     <!--  Skip existing files  -->
                     <DockPanel
                         Background="Transparent"
                         LastChildFill="False"
-                        ToolTip="When selecting multiple videos to download, skip those that already have a matching file in the target directory">
+                        ToolTip="When selecting multiple videos to download, skip those that already have matching files in the target directory">
                         <TextBlock
                             Margin="16,8"
                             DockPanel.Dock="Left"
@@ -129,7 +144,7 @@
                         Margin="16,8"
                         Background="Transparent"
                         LastChildFill="False"
-                        ToolTip="How many downloads can be active at one time">
+                        ToolTip="How many downloads can be active at the same time">
                         <TextBlock
                             VerticalAlignment="Center"
                             DockPanel.Dock="Left"