Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected State With City Screen #96

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

arunkbabu90
Copy link

@arunkbabu90 arunkbabu90 commented May 12, 2018

Description

Fully Implemented SelectedStatesActivity which now includes both City and Places screens in one TabLayout activity.
Note that this PR is an extension of @ibhavikmakwana 's issue #78 which only has the Places screen.
Also note that this activity is not connected any screens right now; so you need to manually create an intent to launch the *SelectedStatesActivity.java in-order to view this activity

IMPORTANT: Firstly merge the PR of Issue #78 & then merge this PR

Fixes #79

Type of Change:

  • User Interface

How Has This Been Tested?

I tested this on Android Studio's Emulator and on my Physical Device. Since this activity is not linked to any other items/screens right now. I verified the changes by creating an intent manually in the LogOut menu's item-selected-event in the HomeActivity. This intent is now deleted from LogOut menu to maintain its original functionality, so to view this activity again you need the create an intent manually

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • Any dependent changes have been merged

@Rondaul
Copy link
Collaborator

Rondaul commented May 14, 2018

Please resolved merge conflicts and and a screentshot of your layout.

@arunkbabu90
Copy link
Author

I've resolved all the merge conflicts @Rondaul.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants