Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize Type Definitions #70

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

PedroCo3lho
Copy link
Contributor

Description

Added type folder in apps/web/src/types/index.ts and moved types from local page.tsx files to /types/index.ts
closes #58

Checklist

  • The title of the PR is clear and descriptive.
  • All tests have been run and passed.
  • Code follows project conventions (Biome formatting, linting).
  • Documentation has been updated as needed.
  • Commit messages follow the Conventional Commits style.

Type of Change

  • Bugfix
  • Feature
  • Refactor
  • Chore
  • Documentation
  • Test

Testing

Manual Testing

Automated Tests

  • Unit tests added or updated
  • Integration tests added or updated
  • E2E tests added or updated

Additional Notes

I notice there is some interfaces through the repo, i can also centralize them, if makes sense let me know then i can implement.
If you want some structure, file or logic change please comment bellow or reach in me in Telegram, thanks!

Copy link

vercel bot commented Nov 25, 2024

@PedroCo3lho is attempting to deploy a commit to the CofiBlocks Team on Vercel.

A member of the Team first needs to authorize it.

@rvalenciano rvalenciano merged commit b511940 into Vagabonds-Labs:main Nov 29, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Centralize Type Definitions
2 participants