Treat UTF-16 strings in binary VDF as little-endian

Integers in binary VDF are already treated as little-endian (least significant byte first) regardless of CPU architecture, but the 16-bit units in UTF-16 didn't get the same treatment. This led to a test failure on big-endian machines. Resolves: #33 Signed-off-by: Simon McVittie <[email protected]>
ValvePython · Dec 15, 2023 · fe85ab8 · fe85ab8
1 parent d762926
commit fe85ab8
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/vdf/__init__.py b/vdf/__init__.py
@@ -361,7 +361,7 @@ def read_string(fp, wide=False):
         result = buf[:end]
 
         if wide:
-            result = result.decode('utf-16')
+            result = result.decode('utf-16le')
         elif bytes is not str:
             result = result.decode('utf-8', 'replace')
         else:
@@ -469,7 +469,7 @@ def _binary_dump_gen(obj, level=0, alt_format=False):
                 value = value.encode('utf-8') + BIN_NONE
                 yield BIN_STRING
             except:
-                value = value.encode('utf-16') + BIN_NONE*2
+                value = value.encode('utf-16le') + BIN_NONE*2
                 yield BIN_WIDESTRING
             yield key + BIN_NONE + value
         elif isinstance(value, float):