Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pledge Only Users #176

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Conversation

cj13579
Copy link
Contributor

@cj13579 cj13579 commented Dec 31, 2024

This PR is dependent on #149.

I host a year-round wishlist for my family. I like for people to be able to login and pledge items for people in our family but I don't want to host wish lists for my extended family or friends who may want to use our family's lists to pledge items. To solve this, I propose a new user type: the "pledge only" user.

When a user is marked as "pledge only", either when they are created or at some point in the future by an administrator, the following capabilities are restricted:

  1. The pledge only user does not see their own wishlist in the list of wishlists
  2. The pledge only user does not see a "my wishlist" option in the navbar menu
  3. Others do not see a wishlist for that user in the list of wishlists

Screenshot 2024-12-31 102020

If you are someone who hosts Christmas Community for others but are not participating in the gifting, Admins can also be pledge only too.

Because this is just a boolean on the user object, users can be easily converted between pledge only and "normal" users. This can be done by an Administrator:

image

I have also added support for a couple of new options:

  • PLEDGE_SUGGEST (environment variable): When set to false, suggesting items to a wishlist is disabled for pledge only users. An informational message is shown to indicate that item suggestions are disabled. By default this is true protecting the behavior of the application as it is today.
  • SUGGESTIONS_ENABLED (environment variable): When set to false, suggesting items to a wishlist is disabled for all users. An informational message is shown to indicate that item suggestions are disabled. By default this is true protecting the behavior of the application as it is today.

Screenshot 2024-12-31 105731

I think that with the addition of the above two options, issue #116 could be considered resolved.

github-actions bot and others added 24 commits September 24, 2024 01:56
* docs(contributor): contrib-readme-action has updated readme

* Move item to bottom of list

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
)

* Set location of PouchDB log file with environment variable.

* Use config system

* Use config system

---------

Co-authored-by: Wingy <[email protected]>
* Added automation to keep contributers section current

* Updated README.md to use new automation to keep contributers current

* changed branch name

* fix: Added backslashes and typescript install to Dockerfile

* fix: Dockerfile, allow changes to be applied

---------

Co-authored-by: jskidie <[email protected]>
@cj13579
Copy link
Contributor Author

cj13579 commented Dec 31, 2024

I think that this also solves #8

@cj13579 cj13579 changed the title Pledge Only Users feat: Pledge Only Users Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants