Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Nuxt to v.2.16.3 #952

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Update Nuxt to v.2.16.3 #952

merged 1 commit into from
Mar 22, 2023

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Mar 20, 2023 •
edited
Loading

Fixes

Related to #411 by @obulat

Description

As the first step towards migrating to Nuxt 3, we need to update Nuxt to version 2.16. This update was blocked by inability to configure the postcss-preset-env. With the default settings, all the logical CSS properties we need to maintain the RTL layout were converted to the default. So, for example, margin-inline-start was always converted to margin-left, instead of being margin-left for LTR layouts, and margin-right for RTL layouts.

This problem was fixed in Nuxt version 2.16.3.

Code changes made in this update:

  • build.postcss in nuxt.config now uses postcssOptions inner property
  • JS module fix in nuxt.config is not needed anymore
  • postcss8 is used by default, so we no longer need a separate Nuxt module for it.
  • typescript-build has also been updated to version 3

Testing Instructions

CI should pass

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: frontend Related to the Nuxt frontend labels Mar 20, 2023
@obulat obulat requested a review from a team as a code owner March 20, 2023 06:27
@obulat obulat requested review from zackkrida and dhruvkb March 20, 2023 06:27
@github-actions
Copy link

Size Change: -34.6 kB (-4%)

Total Size: 847 kB

Filename Size Change
./frontend/.nuxt/dist/client/app.js 125 kB -17.9 kB (-13%) 👏
./frontend/.nuxt/dist/client/app.modern.js 117 kB -517 B (0%)
./frontend/.nuxt/dist/client/commons/app.js 90.3 kB +2.53 kB (+3%)
./frontend/.nuxt/dist/client/commons/app.modern.js 78.5 kB +247 B (0%)
./frontend/.nuxt/dist/client/components/v-all-results-grid.js 5.62 kB -2.4 kB (-30%) 🎉
./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js 5.45 kB -41 B (-1%)
./frontend/.nuxt/dist/client/components/v-audio-details.js 1.82 kB -727 B (-28%) 🎉
./frontend/.nuxt/dist/client/components/v-audio-track.js 5.24 kB +18 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-track.modern.js 5.2 kB +28 B (+1%)
./frontend/.nuxt/dist/client/components/v-box-layout.js 1.28 kB +38 B (+3%)
./frontend/.nuxt/dist/client/components/v-box-layout.modern.js 1.28 kB +39 B (+3%)
./frontend/.nuxt/dist/client/components/v-content-report-form.js 3.79 kB -2.32 kB (-38%) 🎉
./frontend/.nuxt/dist/client/components/v-content-report-popover.js 4.45 kB +3.21 kB (+260%) 🆘
./frontend/.nuxt/dist/client/components/v-image-details.js 1.44 kB -726 B (-34%) 🎉
./frontend/.nuxt/dist/client/components/v-image-grid.js 2.64 kB -2.35 kB (-47%) 🎉
./frontend/.nuxt/dist/client/components/v-load-more.js 799 B -2.37 kB (-75%) 🏆
./frontend/.nuxt/dist/client/components/v-radio.js 1.52 kB +12 B (+1%)
./frontend/.nuxt/dist/client/components/v-related-images.js 3.22 kB +2.16 kB (+204%) 🆘
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js 1.01 kB -2.38 kB (-70%) 🏆
./frontend/.nuxt/dist/client/components/v-snackbar.js 1.16 kB -29 B (-2%)
./frontend/.nuxt/dist/client/components/v-snackbar.modern.js 1.16 kB -28 B (-2%)
./frontend/.nuxt/dist/client/components/v-sources-table.js 15 kB -1.19 kB (-7%) ✅
./frontend/.nuxt/dist/client/components/v-sources-table.modern.js 15 kB -1.19 kB (-7%) ✅
./frontend/.nuxt/dist/client/pages/audio/_id/index.js 5.02 kB -3 kB (-37%) 🎉
./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js 4.87 kB +14 B (0%)
./frontend/.nuxt/dist/client/pages/image/_id/index.js 5.41 kB -3.92 kB (-42%) 🎉
./frontend/.nuxt/dist/client/pages/image/_id/report.js 4.56 kB +901 B (+25%) 🚨
./frontend/.nuxt/dist/client/pages/search.js 2.2 kB -2.36 kB (-52%) 🏆
./frontend/.nuxt/dist/client/pages/search/audio.js 3.59 kB -2.43 kB (-40%) 🎉
./frontend/.nuxt/dist/client/pages/search/audio.modern.js 3.5 kB -42 B (-1%)
./frontend/.nuxt/dist/client/pages/search/image.js 2.81 kB +2.31 kB (+455%) 🆘
./frontend/.nuxt/dist/client/vendors/app.js 64.1 kB -94 B (0%)
./frontend/.nuxt/dist/client/vendors/app.modern.js 63.3 kB -46 B (0%)
ℹ️ View Unchanged
Filename Size Change
./frontend/.nuxt/dist/client/235.js 273 B 0 B
./frontend/.nuxt/dist/client/235.modern.js 278 B 0 B
./frontend/.nuxt/dist/client/236.js 1.85 kB 0 B
./frontend/.nuxt/dist/client/components/loading-icon.js 751 B +5 B (+1%)
./frontend/.nuxt/dist/client/components/loading-icon.modern.js 756 B +3 B (0%)
./frontend/.nuxt/dist/client/components/table-sort-icon.js 515 B +1 B (0%)
./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js 519 B 0 B
./frontend/.nuxt/dist/client/components/v-audio-cell.js 392 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-cell.modern.js 397 B 0 B
./frontend/.nuxt/dist/client/components/v-audio-details.modern.js 1.8 kB +7 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js 1.02 kB -2 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 1.02 kB -3 B (0%)
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js 542 B 0 B
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 546 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-bone.js 688 B -4 B (-1%)
./frontend/.nuxt/dist/client/components/v-bone.modern.js 693 B -4 B (-1%)
./frontend/.nuxt/dist/client/components/v-content-link.js 1.12 kB -2 B (0%)
./frontend/.nuxt/dist/client/components/v-content-link.modern.js 1.1 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-content-page.js 526 B 0 B
./frontend/.nuxt/dist/client/components/v-content-page.modern.js 529 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-button.js 783 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js 789 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js 3.6 kB +6 B (0%)
./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js 4.25 kB +6 B (0%)
./frontend/.nuxt/dist/client/components/v-copy-button.js 4 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-copy-button.modern.js 4.01 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-copy-license.js 1 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-license.modern.js 1.01 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.js 9.96 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.modern.js 9.93 kB -4 B (0%)
./frontend/.nuxt/dist/client/components/v-dmca-notice.js 753 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js 759 B 0 B
./frontend/.nuxt/dist/client/components/v-error-image.js 1.69 kB -8 B (0%)
./frontend/.nuxt/dist/client/components/v-error-image.modern.js 1.68 kB -4 B (0%)
./frontend/.nuxt/dist/client/components/v-error-section.js 372 B 0 B
./frontend/.nuxt/dist/client/components/v-error-section.modern.js 375 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-external-search-form.js 1.92 kB +4 B (0%)
./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js 1.91 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-external-source-list.js 904 B +1 B (0%)
./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js 906 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-full-layout.js 1.52 kB -5 B (0%)
./frontend/.nuxt/dist/client/components/v-full-layout.modern.js 1.52 kB -4 B (0%)
./frontend/.nuxt/dist/client/components/v-grid-skeleton.js 1.61 kB -4 B (0%)
./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.62 kB -6 B (0%)
./frontend/.nuxt/dist/client/components/v-home-gallery.js 5.18 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js 5.17 kB 0 B
./frontend/.nuxt/dist/client/components/v-homepage-content.js 1.76 kB -2 B (0%)
./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js 1.73 kB -2 B (0%)
./frontend/.nuxt/dist/client/components/v-image-carousel.js 4.74 kB +4 B (0%)
./frontend/.nuxt/dist/client/components/v-image-carousel.modern.js 4.71 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-image-cell.js 1.57 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-image-cell.modern.js 1.56 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-image-details.modern.js 1.43 kB -5 B (0%)
./frontend/.nuxt/dist/client/components/v-image-grid.modern.js 2.51 kB -3 B (0%)
./frontend/.nuxt/dist/client/components/v-license-tab-panel.js 526 B 0 B
./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js 529 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-load-more.modern.js 694 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-media-license.js 829 B +2 B (0%)
./frontend/.nuxt/dist/client/components/v-media-license.modern.js 837 B 0 B
./frontend/.nuxt/dist/client/components/v-media-reuse.js 1.63 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js 1.63 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-media-tag.js 434 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-media-tag.modern.js 439 B 0 B
./frontend/.nuxt/dist/client/components/v-modal.js 1 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-modal.modern.js 996 B 0 B
./frontend/.nuxt/dist/client/components/v-no-results.js 757 B 0 B
./frontend/.nuxt/dist/client/components/v-no-results.modern.js 755 B 0 B
./frontend/.nuxt/dist/client/components/v-radio.modern.js 1.48 kB +7 B (0%)
./frontend/.nuxt/dist/client/components/v-related-audio.js 1.27 kB +4 B (0%)
./frontend/.nuxt/dist/client/components/v-related-audio.modern.js 1.27 kB +3 B (0%)
./frontend/.nuxt/dist/client/components/v-related-images.modern.js 3.09 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-report-desc-form.js 978 B 0 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js 979 B -2 B (0%)
./frontend/.nuxt/dist/client/components/v-row-layout.js 1.71 kB -8 B (0%)
./frontend/.nuxt/dist/client/components/v-row-layout.modern.js 1.71 kB -7 B (0%)
./frontend/.nuxt/dist/client/components/v-scroll-button.js 824 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js 830 B 0 B
./frontend/.nuxt/dist/client/components/v-search-grid.js 5.75 kB -7 B (0%)
./frontend/.nuxt/dist/client/components/v-search-grid.modern.js 5.67 kB -5 B (0%)
./frontend/.nuxt/dist/client/components/v-search-results-title.js 601 B +1 B (0%)
./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js 605 B 0 B
./frontend/.nuxt/dist/client/components/v-search-type-radio.js 805 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-search-type-radio.modern.js 780 B 0 B
./frontend/.nuxt/dist/client/components/v-server-timeout.js 299 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-server-timeout.modern.js 303 B 0 B
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 913 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-warning-suppressor.js 306 B 0 B
./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js 311 B 0 B
./frontend/.nuxt/dist/client/pages/about.js 1.4 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/about.modern.js 1.4 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/external-sources.js 1.56 kB +2 B (0%)
./frontend/.nuxt/dist/client/pages/external-sources.modern.js 1.57 kB +5 B (0%)
./frontend/.nuxt/dist/client/pages/feedback.js 1.34 kB -2 B (0%)
./frontend/.nuxt/dist/client/pages/feedback.modern.js 1.34 kB +2 B (0%)
./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js 5.17 kB -4 B (0%)
./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js 4.27 kB +6 B (0%)
./frontend/.nuxt/dist/client/pages/index.js 7.28 kB +3 B (0%)
./frontend/.nuxt/dist/client/pages/index.modern.js 7.21 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/preferences.js 1.32 kB -4 B (0%)
./frontend/.nuxt/dist/client/pages/preferences.modern.js 1.32 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/privacy.js 1.01 kB -2 B (0%)
./frontend/.nuxt/dist/client/pages/privacy.modern.js 1.02 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/search-help.js 1.6 kB 0 B
./frontend/.nuxt/dist/client/pages/search-help.modern.js 1.58 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/search.modern.js 2.04 kB +2 B (0%)
./frontend/.nuxt/dist/client/pages/search/image.modern.js 2.7 kB -5 B (0%)
./frontend/.nuxt/dist/client/pages/search/index.js 444 B +2 B (0%)
./frontend/.nuxt/dist/client/pages/search/index.modern.js 448 B +1 B (0%)
./frontend/.nuxt/dist/client/pages/search/model-3d.js 243 B 0 B
./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js 246 B 0 B
./frontend/.nuxt/dist/client/pages/search/search-page.types.js 266 B 0 B
./frontend/.nuxt/dist/client/pages/search/search-page.types.modern.js 271 B 0 B
./frontend/.nuxt/dist/client/pages/search/video.js 240 B 0 B
./frontend/.nuxt/dist/client/pages/search/video.modern.js 244 B 0 B
./frontend/.nuxt/dist/client/pages/sources.js 1.57 kB 0 B
./frontend/.nuxt/dist/client/pages/sources.modern.js 1.57 kB -3 B (0%)
./frontend/.nuxt/dist/client/runtime.js 2.72 kB +3 B (0%)
./frontend/.nuxt/dist/client/runtime.modern.js 2.73 kB 0 B

compressed-size-action

@github-actions
Copy link

github-actions bot commented Mar 20, 2023 •
edited
Loading

Full-stack documentation: Ready

https://WordPress.github.io/openverse/_preview/952

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

dhruvkb
dhruvkb approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the VR and e2e tests passing is proof enough that everything continues to work after the update. Thanks @obulat for the upstream fix!

sarayourfriend
sarayourfriend approved these changes Mar 22, 2023
View reviewed changes
Copy link
Collaborator

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@obulat obulat merged commit fd765d0 into main Mar 22, 2023
@obulat obulat deleted the update/nuxt2.16 branch March 22, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvkb dhruvkb dhruvkb approved these changes

@sarayourfriend sarayourfriend sarayourfriend approved these changes

@zackkrida zackkrida Awaiting requested review from zackkrida zackkrida is a code owner automatically assigned from WordPress/openverse-frontend

Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@obulat @dhruvkb @sarayourfriend