Fixes the incorrect stemming of the verb "revocares" and of a word that looks like a verb but is not

[iolse]

Context

• Our Spanish stemmer doesn't yet perform well in all the tests we initially wrote for Spanish words, e.g., verb forms.

Summary

This PR can be summarized in the following changelog entry:

• [yoastseo] Improves the verb suffixes recognition and stemming in Spanish.
• [wordpress-seo-premium] Improves the stemming of Spanish verbs ending in common suffixes, e.g., "revocares" which was incorrectly stemmed to "revocar", now it's stemmed to "revoc". Also, Adds the verb to the list of verbs with stem modifications to improve accuracy.

Relevant technical choices:

• Even though when running the calculateCoverage file it now states: The current coverage of the Spanish stemmer is 99.97541185148758 %. The number of errors is 2., the two errors in question refer in fact to the correct stemming of the words lugar and práxedes , which where incorrectly stemmed in the previous version of the stemmer.
• Documentation of on how to create the goldStandard list had been updated since the path to the generateStem file does not live in yoastseo/package.json but in yoastseo/jest.config.js. Also, instructions for formatting have been updated to avoid indentation in the goldStandard list.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• Run yarn test and make sure that everything passes
• Build the content-analysis app and set the use morphology tag on
• Set the locale language to Spanish (es_ES)
• Add a text of at least 300 words
• Add word revocares, revoca, revoque in the text
• Add word revocar as the keyphrase
• In keyphrase density assessment, the focus keyphrase should be found 3 times
• Check that the words are highlighted

Test words that are not verbs

• Set lugar as keyphrase
• Add lugar and lugares to the text
• In keyphrase density assessment, the focus keyphrase should be found 2 times
• Check that the words are highlighted
• Set práxedes as keyphrase
• Add práxedes and praxedes to the text
• In keyphrase density assessment, the focus keyphrase should be found 2 times
• Check that the words are highlighted

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/lingo-other-tasks/issues/234

[coveralls]

Pull Request Test Coverage Report for Build 9e0b93fe464dab0056be8406f85a53fb90ddd0ca

Details

• 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.01%) to 54.508%

---

Totals
Change from base Build 0e3afd51407d6e626b0c7b7da63a3f2929854567:	0.01%
Covered Lines:	30206
Relevant Lines:	55848

---

💛 - Coveralls