Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove experimental features from release builds #9222

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gustavovalverde
Copy link
Member

Motivation

Experimental features are no longer built into release images. Users must now build custom images with specific features if needed.

Closes #9210
Closes #9204
Partially #7415

Solution

  • Remove experimental build job from release workflow
  • Remove experimental features from CI matrix
  • Update documentation to reflect new feature strategy
  • Simplify Dockerfile by removing experimental feature args
  • Keep RUN_ALL_EXPERIMENTAL_TESTS for testing purposes only

Notes

Migration: Users who need specific features should:

  1. Build custom images using --build-arg FEATURES="feature1 feature2"
  2. Use the documented feature flags in their builds
  3. Refer to the new documentation for building with custom features

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

BREAKING CHANGE: Experimental features are no longer built into release images.
Users must now build custom images with specific features if needed.

- Remove experimental build job from release workflow
- Remove experimental features from CI matrix
- Update documentation to reflect new feature strategy
- Simplify Dockerfile by removing experimental feature args
- Keep RUN_ALL_EXPERIMENTAL_TESTS for testing purposes only

Migration: Users who need specific features should:
1. Build custom images using --build-arg FEATURES="feature1 feature2"
2. Use the documented feature flags in their builds
3. Refer to the new documentation for building with custom features

Closes  #9210
Closes #9204
Partially #7415
@gustavovalverde gustavovalverde added A-docs Area: Documentation A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup P-High 🔥 labels Feb 10, 2025
@gustavovalverde gustavovalverde self-assigned this Feb 10, 2025
@gustavovalverde gustavovalverde requested review from a team as code owners February 10, 2025 15:24
@gustavovalverde gustavovalverde requested review from oxarbitrage and upbqdn and removed request for a team and oxarbitrage February 10, 2025 15:24
@github-actions github-actions bot added C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge labels Feb 10, 2025
Enable passing experimental features to Docker test runs by:
- Updating workflow configuration to pass EXPERIMENTAL_FEATURES
- Modifying entrypoint script to include experimental features during test execution
- Documenting new experimental test category in workflow README
@mpguerra mpguerra linked an issue Feb 11, 2025 that may be closed by this pull request
Copy link
Member

@upbqdn upbqdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'll be easier if we merge #8923 first since it also simplifies passing Rust features to the images using only a single variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-docs Area: Documentation C-cleanup Category: This is a cleanup C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge P-High 🔥
Projects
None yet
2 participants