Stop GitHub workflows from failing on forks #9257
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two workflows that have bugs in them: - cd-deploy-nodes-gcp is missing a job name, which is then depended-on later - sub-ci-integration-tests-gcp changed the name of a job without changing its dependents
There are various GitHub CI jobs that won’t work on forks. E.g., some need credentials for ZF’s DockerHub or GCP accounts. Unfortunately, you can’t prevent entire workflows from running this way, but this disables a minimal number of jobs to keep forks from failing whenever `main` is pushed to.
github-actions
bot
added
the
C-trivial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Various workflows fail whenever I push to
mainon my fork. And one workflow is on a cron job which runs daily and emails me every day.The failures are generally due to something like needing ZF credentials for some service, like DockerHub or GCP.
Solution
This disables a bunch of CI jobs if they are run outside of the ZcashFoundation org.
There are also two workflows that simply had bugs in them. Those have also been fixed. Both bugs are caught by GitHub’s workflow file checks, so neither workflow gets run (i.e., they are not logic bugs in the steps that are performed, but references from one job to a job that doesn’t exist).
Tests
Basically pushing these changes to
mainon my fork until I don’t get any failures. Some of the workflows don’t run right away, so it’s possible another failure may show up in a day.PR Author's Checklist
PR Reviewer's Checklist