fix(relations): refactor js and add it to forms Media class #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reinit_select2 functionality is now in a separate `rel_reinit_select2` function which is run every time the js is included *and* when the `reinit_select2` trigger is received (though not sure if thats even needed now). In addition the javascript is included in the relation forms Media class, so that the js is included with every relation form and thus the `rel_reinit_select2` function is executed everytime the form in loaded which is what we actually want to make the select2 work everytime. Closes: #1544
b1rger
force-pushed
the
birger/1544-rel-dialog-select2
branch
from
7393678 to
5bc4f08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reinit_select2 functionality is now in a separate
rel_reinit_select2function which is run every time the js is includedand when the
reinit_select2trigger is received (though not sure ifthats even needed now).
In addition the javascript is included in the relation forms Media
class, so that the js is included with every relation form and thus the
rel_reinit_select2function is executed everytime the form in loadedwhich is what we actually want to make the select2 work everytime.
Closes: #1544