Update build logic #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- AGP 8: Java 17 JDK required - Configure maven-publish plugin
yjtyujie
commented
Jul 20, 2024
| implementation project(path: ':horizontalpickerlib') | ||
|
|
||
| implementation(platform("org.jetbrains.kotlin:kotlin-bom:1.9.24")) |
There was a problem hiding this comment.
Needed to fix an issue with duplicate copies of the kotlin-stdlib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on JDK 17
AGP updated to 8.5.1
Gradle wrapper updated to 8.9
Update dependencies
This is basically to make forks easier, because anyone who's still using this library will most likely have to maintain their own changes for their use case.
I also added the maven-publish plugin in case publishing this library to Maven Central is a priority (#15), but also helps for people using mavenLocal to integrate their own changes
No impact on compatibility, the library continues to target Java 8 with minSdk 14