Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Remix/Result links to a new tab #7

Merged
merged 1 commit into from
May 14, 2017

Conversation

bobchao
Copy link
Contributor

@bobchao bobchao commented May 14, 2017

Per the request in issue #3

@bobchao
Copy link
Contributor Author

bobchao commented May 14, 2017

For others who has already did some l10n work, you can still cast a regexp replace:

Replace

[(View Result|Remix Lesson on Glitch|Remix the A-Frame Starter Glitch|Open Example on Glitch)]((.+))

to

<a href="$2" target="_blank">$1</a>

@ngokevin ngokevin merged commit 33abcb3 into aframevr:master May 14, 2017
@bobchao bobchao deleted the links-to-new-tab branch May 17, 2017 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants