[PR #10107/84bb77d1 backport][3.11] Use internal self._headers var in FileResponse
#10108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
(cherry picked from commit 84bb77d)
bdraco
approved these changes
Dec 4, 2024
CodSpeed Performance ReportMerging #10108 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.11 #10108 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 123 123
Lines 37113 37113
Branches 4466 4466
=======================================
Hits 36395 36395
Misses 540 540
Partials 178 178
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
deleted the
patchback/backports/3.11/84bb77d14484c04561fabb7ad628aee903531955/pr-10107
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #10107 as merged into master (84bb77d).
The
preparepath called the publicself.headersproperty which has to do a property lookup each time. As we are alreadyinside the object we can use
self._headersinstead. This change alignsweb_fileresponsewithweb_responsewhich usesself._headersand notself.headers. This change will not make a significant difference in performance but will make the profile a bit easier to read.