Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #10114/94569554 backport][3.12] Add 304 benchmark for FileResponse #10116

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Dec 5, 2024

This is a backport of PR #10114 as merged into master (9456955).

related issue #10112
related comment #8013 (comment)
needed to prove out #10113

@patchback patchback bot requested a review from asvetlov as a code owner December 5, 2024 15:37
@bdraco bdraco enabled auto-merge (squash) December 5, 2024 15:46
Copy link

codspeed-hq bot commented Dec 5, 2024

CodSpeed Performance Report

Merging #10116 will not alter performance

Comparing patchback/backports/3.12/9456955401cb8e78c363a92d829d924ef87bd004/pr-10114 (8d9815e) with 3.12 (8745cf4)

Summary

✅ 46 untouched benchmarks
🆕 1 new benchmarks

Benchmarks breakdown

Benchmark 3.12 patchback/backports/3.12/9456955401cb8e78c363a92d829d924ef87bd004/pr-10114 Change
🆕 test_simple_web_file_response_not_modified[pyloop] N/A 67.9 ms N/A

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (8745cf4) to head (8d9815e).
Report is 1 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.12   #10116   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         123      123           
  Lines       37112    37137   +25     
  Branches     4466     4468    +2     
=======================================
+ Hits        36394    36419   +25     
  Misses        540      540           
  Partials      178      178           
Flag Coverage Δ
CI-GHA 97.95% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.66% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.58% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.77% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.63% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.16% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.23% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 96.69% <100.00%> (-0.01%) ⬇️
Py-3.12.7 97.72% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 96.56% <100.00%> (+<0.01%) ⬆️
Py-3.13.1 97.68% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.55% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.13% <100.00%> (+0.01%) ⬆️
Py-pypy7.3.16 96.70% <100.00%> (+<0.01%) ⬆️
VM-macos 96.77% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.66% <100.00%> (+<0.01%) ⬆️
VM-windows 94.58% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit cd0c2c8 into 3.12 Dec 5, 2024
33 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/9456955401cb8e78c363a92d829d924ef87bd004/pr-10114 branch December 5, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant