-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add host parameter to aiohttp_server fixture (#10120) #10121
Add host parameter to aiohttp_server fixture (#10120) #10121
Conversation
CodSpeed Performance ReportMerging #10121 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10121 +/- ##
==========================================
- Coverage 98.76% 98.75% -0.01%
==========================================
Files 122 122
Lines 36958 36954 -4
Branches 4408 4411 +3
==========================================
- Hits 36500 36494 -6
- Misses 311 313 +2
Partials 147 147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
37f845a
to
a33f9ec
Compare
Add host parameter to aiohttp_server fixture to allow access from non local clients, e.g. running in docker containers.
for more information, see https://pre-commit.ci
d1b04b8
to
d8946d7
Compare
Backport to 3.12: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 7f8e2d3 on top of patchback/backports/3.12/7f8e2d35ad4d0d5fed82721060bafd1bafa264b8/pr-10121 Backporting merged PR #10121 into master
🤖 @patchback |
Co-authored-by: ChristianWBrock <christian.brock AT posteo.net> (cherry picked from commit 7f8e2d3) Co-authored-by: christianwbrock <[email protected]>
Fixes #10120
It adds a host parameter to the aiohttp_server fixture to allow access
from non local clients, e.g. running in docker containers.