Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE #10129

Merged
merged 23 commits into from
Dec 6, 2024
Merged

DO NOT MERGE #10129

merged 23 commits into from
Dec 6, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 5, 2024

No description provided.

bdraco and others added 23 commits December 1, 2024 23:44
…a in the stream reader twice (#10090)

Co-authored-by: J. Nick Koston <[email protected]>
…a in the stream reader twice (#10091)

Co-authored-by: J. Nick Koston <[email protected]>
…base url (#10094)

**This is a backport of PR #10074 as merged into master
(f733258).**
Co-authored-by: vivodi <[email protected]>
…nse (#10098)

**This is a backport of PR #10095 as merged into master
(fcce1bf).**

We didn't have any benchmarks for file responses. From the benchmarks it
turns out most of the time is creating and processing the executor jobs.

If we combine the stat into a job that returns the open fileobj it will
likely be faster and solve
#8013

Co-authored-by: J. Nick Koston <[email protected]>
…nse (#10097)

**This is a backport of PR #10095 as merged into master
(fcce1bf).**

We didn't have any benchmarks for file responses. From the benchmarks it
turns out most of the time is creating and processing the executor jobs.

If we combine the stat into a job that returns the open fileobj it will
likely be faster and solve
#8013

Co-authored-by: J. Nick Koston <[email protected]>
…pe` for paths with Python 3.13 (#10103)

Co-authored-by: J. Nick Koston <[email protected]>
…pe` for paths with Python 3.13 (#10104)

Co-authored-by: J. Nick Koston <[email protected]>
…e is replaced during `prepare` (#10105)

Co-authored-by: J. Nick Koston <[email protected]>
fixes #8013
…e is replaced during `prepare` (#10106)

Co-authored-by: J. Nick Koston <[email protected]>
fixes #8013
Copy link

codspeed-hq bot commented Dec 6, 2024

CodSpeed Performance Report

Merging #10129 will not alter performance

Comparing do-not-merge (210c381) with master (d58d2c3)

Summary

✅ 47 untouched benchmarks

@bdraco bdraco added the backport:skip Skip backport bot label Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (d58d2c3) to head (210c381).
Report is 23 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10129   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         122      122           
  Lines       36956    36956           
  Branches     4411     4411           
=======================================
  Hits        36494    36494           
  Misses        315      315           
  Partials      147      147           
Flag Coverage Δ
CI-GHA 98.63% <ø> (ø)
OS-Linux 98.32% <ø> (ø)
OS-Windows 96.17% <ø> (ø)
OS-macOS 97.43% <ø> (+<0.01%) ⬆️
Py-3.10.11 97.27% <ø> (+<0.01%) ⬆️
Py-3.10.15 97.86% <ø> (+0.05%) ⬆️
Py-3.11.10 97.85% <ø> (+<0.01%) ⬆️
Py-3.11.9 97.31% <ø> (-0.01%) ⬇️
Py-3.12.7 98.38% <ø> (+<0.01%) ⬆️
Py-3.13.0 97.19% <ø> (+<0.01%) ⬆️
Py-3.13.1 98.34% <ø> (+<0.01%) ⬆️
Py-3.9.13 97.19% <ø> (ø)
Py-3.9.20 97.77% <ø> (ø)
Py-pypy7.3.16 97.34% <ø> (+<0.01%) ⬆️
VM-macos 97.43% <ø> (+<0.01%) ⬆️
VM-ubuntu 98.32% <ø> (ø)
VM-windows 96.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 210c381 into master Dec 6, 2024
40 of 41 checks passed
@bdraco bdraco deleted the do-not-merge branch December 6, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip Skip backport bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant