-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.11] Fix WebSocket reader flow control size calculation for multi-byte data #9686
Conversation
CodSpeed Performance ReportMerging #9686 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.11 #9686 +/- ##
=======================================
Coverage 97.92% 97.92%
=======================================
Files 117 117
Lines 35845 35844 -1
Branches 4295 4294 -1
=======================================
Hits 35101 35101
+ Misses 558 557 -1
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
https://www.merriam-webster.com/dictionary/undercount Hmm.. guess its not in the spelling words |
a11bc73
to
03480f2
Compare
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply ea1c084 on top of patchback/backports/3.10/ea1c084d9f49e91feb2e92fea307260ad3f47376/pr-9686 Backporting merged PR #9686 into 3.11
🤖 @patchback |
…ize calculation for multi-byte data (#9709)
The decoded size was passed to the
FlowControlDataQueue
instead of the bytes size which meant multi-byte characters would be under counted.Note that this code is completely different on 3.11/3.10 than
master
so this PR is directly to 3.11