DNM: test hit rate of a join cache

#1432 (comment)
aio-libs · Nov 29, 2024 · 366fa5a · 366fa5a
1 parent 22544b1
commit 366fa5a
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/yarl/_url.py b/yarl/_url.py
@@ -1357,7 +1357,12 @@ def join(self, url: "URL") -> "URL":
         """
         if type(url) is not URL:
             raise TypeError("url should be URL")
+        # Make sure the argument is a URL so we do not pollute the cache
+        # with invalid URLs
+        return self._join(url)
 
+    @lru_cache
+    def _join(self, url: "URL") -> "URL":
         scheme = url._scheme or self._scheme
         if scheme != self._scheme or scheme not in USES_RELATIVE:
             return url