Update the join fetching exception metrics #907
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the join fetching exception metrics are not recorded correctly.
Metrics.Context(Metrics.Environment.JoinFetching)
doesn't include the join name so the exception is not recorded on join level.The PR changes the behaviors for two types of exceptions:
Why / Goal
Test Plan
Testing the missing key exception:
python3 ~/.local/bin/run.py --mode=fetch --name zipline_test/iceberg_realtime.v0 -k '{"name":null}' -t join --chronon-jar ~/test/chronon-embedded.jar --online-jar ~/test/online-all.jar | tee ~/test/fetch.log
Fetched result:
metrics:
Checklist
Reviewers
@hzding621 @pengyu-hou