Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: make RTL new line a valid character #5434

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

whazor
Copy link
Contributor

@whazor whazor commented Dec 20, 2023

Issue #, if available: #5423

Description of changes:
We create a mechanism for specifying valid control characters. In this way, we can set wished behaviors, without making RTL mode less secure.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

We create a mechanism for specifying valid control characters. In this way, we can set wished behaviors, without making RTL mode less secure.
@whazor whazor marked this pull request as ready for review December 28, 2023 09:03
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.58%. Comparing base (142b607) to head (9692cce).
Report is 136 commits behind head on master.

Files with missing lines Patch % Lines
src/layer/text.js 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5434      +/-   ##
==========================================
- Coverage   87.59%   87.58%   -0.01%     
==========================================
  Files         584      584              
  Lines       46408    46411       +3     
  Branches     7021     7021              
==========================================
+ Hits        40650    40651       +1     
- Misses       5758     5760       +2     
Flag Coverage Δ
unittests 87.58% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akoreman
Copy link
Contributor

Should we add a test covering this new behaviour?

@nightwing
Copy link
Member

Would it be better to just skip the first character if it is rtl mark and keep 5he old code for the rest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants