Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and test for updated skip_tree_item? method #1919

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

ellohez
Copy link
Contributor

@ellohez ellohez commented Feb 6, 2025

Part of the ongoing Trello card
This PR is a small fix for the method which determines which items to skip and adds a test for this method.

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

@ellohez ellohez force-pushed the world-taxon-rake-logging-fix-and-test branch from 4009991 to 9fba62e Compare February 6, 2025 17:01
Copy link
Contributor

@mtaylorgds mtaylorgds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor comment for the test.

spec/lib/world_taxon_update_helper_spec.rb Outdated Show resolved Hide resolved
@ellohez ellohez force-pushed the world-taxon-rake-logging-fix-and-test branch from 9fba62e to 6dbe8cf Compare February 11, 2025 14:40
Copy link
Contributor

@mtaylorgds mtaylorgds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ellohez ellohez merged commit 505bc18 into main Feb 11, 2025
10 checks passed
@ellohez ellohez deleted the world-taxon-rake-logging-fix-and-test branch February 11, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants