Review apps terraform #1745
Open
Review apps terraform #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AP-Hunt
force-pushed
the
review-apps-terraform
branch
7 times, most recently
from
ff56950 to
636738c
Compare
The .review_apps directory will contain Terraform code for deploying a review copy of forms-admin. For now, it contains Terraform version cofiguration and a small amount of documentation in README.md.
AP-Hunt
force-pushed
the
review-apps-terraform
branch
2 times, most recently
from
fd5384e to
fdf6be0
Compare
Checks Terraform style and syntax, and lints it with Checkov
PR number will be used to identify and label a number of things in the deployment.
…bucket `integration/review` from `forms-deploy` exports a bunch of values, like subnet ids and security groups, which will be needed by `.review_apps` to deploy to AWS ECS.
…eview app This a large commit, but also a logical unit. Implements the AWS service and task definitions required to run the forms-admin review app. The task definition runs both forms-admin and forms-api, as well as a local postgres database for them to share. On startup, it uses the standard rails database seeding commands to populate the database with known seed data. The exact configuration is the result of much iteration, and subject to change as forms-admin develops.
The forms-admin and forms-api containers don't have curl installed
…uring a deployment Previously we had to limit the number of deployed tasks for a review app to exactly one, because Traefik would complain about duplicate service names for the duration of the cross over. To avoid that, we add a timestamp to the service name, so they're always unique.
AP-Hunt
force-pushed
the
review-apps-terraform
branch
from
fdf6be0 to
bcee520
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/u0AOLJYF/579-terraform-for-deploying-forms-admin-to-integration-ecs-cluster
Introduces a small amount of Terraform into the repository for use in deploying a
forms-adminreview app. Alongside the Terraform is a GitHub Actions workflow for testing and validating it.This is a large PR, and is expected to not be the final product.
Future PRs will introduce a GitHub Actions workflow for applying the Terraform in response to new pull requests.
Things to consider when reviewing