Change "Question x's routes" page #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfdebrux
force-pushed
the
ldeb-change-routes-show
branch
2 times, most recently
from
ae9e6d8 to
4091287
Compare
lfdebrux
force-pushed
the
ldeb-change-routes-show
branch
2 times, most recently
from
09dcf92 to
85a48f4
Compare
thomasiles
approved these changes
Feb 10, 2025
- Replace `ul` with `p` - Use `routes` instead of `page.routing_conditions`
Make sure that when setting up a form with lots of pages with the `:ready_for_routing` trait that those pages are correctly set up with all the proper metadata.
lfdebrux
force-pushed
the
ldeb-change-routes-show
branch
from
85a48f4 to
0a93b8d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/6qRDmaOg/2095-changes-to-question-xs-routes-page-to-make-it-clearer
Tweak the design and layout of the "Question x's routes" page.
Screen recording
Screen recording of adding a secondary skip route to a form via the edit routes page for an existing route.
Kapture.2025-02-06.at.14.21.43.mp4
Things to consider when reviewing