Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change labels for routes in page list #1754

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Change labels for routes in page list #1754

merged 2 commits into from
Feb 10, 2025

Conversation

lfdebrux
Copy link
Member

@lfdebrux lfdebrux commented Feb 6, 2025 •
edited
Loading

What problem does this pull request solve?

Trello card: https://trello.com/c/GyEfMdbM/2122-change-labels-for-routes-on-add-and-edit-your-questions-page

Screenshots

Screenshot of "Add and edit your questions" page with these changes

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

@lfdebrux lfdebrux marked this pull request as ready for review February 7, 2025 16:32
@lfdebrux lfdebrux force-pushed the ldeb-change-page-list-route-labels branch from d17d1a9 to 73065bc Compare February 7, 2025 16:33
thomasiles
thomasiles reviewed Feb 10, 2025
View reviewed changes
config/locales/en.yml Outdated Show resolved Hide resolved
@lfdebrux lfdebrux force-pushed the ldeb-change-page-list-route-labels branch from 73065bc to 958ed81 Compare February 10, 2025 14:06
thomasiles
thomasiles approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@thomasiles thomasiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@lfdebrux lfdebrux force-pushed the ldeb-change-page-list-route-labels branch from 958ed81 to 4f672b0 Compare February 10, 2025 14:29
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@lfdebrux lfdebrux merged commit 5697324 into main Feb 10, 2025
4 checks passed
@lfdebrux lfdebrux deleted the ldeb-change-page-list-route-labels branch February 10, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasiles thomasiles thomasiles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lfdebrux @thomasiles