Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name of default route/secondary skip route to "any other answer" #1762

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

lfdebrux
Copy link
Member

@lfdebrux lfdebrux commented Feb 7, 2025

What problem does this pull request solve?

Trello card: https://trello.com/c/yW68wpBI/2121-change-route-2-name-to-route-for-any-other-answer-in-several-places

We think it will make it clearer what the secondary skip route is to call it the "any other answer" route.

Screenshots

Screenshot of the "Question x's routes" page with a summary card for a secondary skip route

Screenshot of the page to set questions to skip for secondary skip route

Screenshot of the page to confirm deletion of a secondary skip route

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

@lfdebrux lfdebrux marked this pull request as ready for review February 7, 2025 16:32
@lfdebrux lfdebrux force-pushed the ldeb-rename-any-other-answer-route branch from 2fd4178 to 228350b Compare February 7, 2025 16:33
Copy link
Contributor

@thomasiles thomasiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

We think it will make it clearer what the secondary skip route is to
call it the "any other answer" route.

This commit makes the following changes:
- Change the heading of the default route summary card to "Route for
  any other answer"
- Change the heading of the edit secondary skip route page to "Set
  questions to skip"
- Change the heading of the delete secondary skip route page to "Are you
  sure you want to delete the route for any other answer?"
- Change the blank error message on the delete secondary skip route page
  to "Select ‘Yes’ to delete the route"
@lfdebrux lfdebrux force-pushed the ldeb-rename-any-other-answer-route branch from 228350b to 1d432e4 Compare February 10, 2025 13:38
@lfdebrux lfdebrux enabled auto-merge February 10, 2025 13:38
@lfdebrux lfdebrux merged commit f96cedd into main Feb 10, 2025
4 checks passed
@lfdebrux lfdebrux deleted the ldeb-rename-any-other-answer-route branch February 10, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants