Prototype for making it easier to link to specific sections by headings #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for easy linking to sections
Anchors are spaced better
|
You can preview this change here: Built with commit 96b89ed https://deploy-preview-1004--govuk-design-system-preview.netlify.com |
NickColley
commented
Jul 30, 2019
| </td> | ||
| </tr> | ||
| {% endfor %} | ||
| <tr> |
There was a problem hiding this comment.
This needs to be flattened so the HTML doesnt get confused, not sure another way.
|
If people like this approach I can tidy up the code and get it ready for review. |
NickColley
changed the title
|
I talked to @DebsDee and we want to explore being more consistent with the H2 side navigation before doing something like this as we're concerned about the accessibility impact.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this as a result of my messing around with different approaches.
The main controversial aspect of this approach is that it's intentionally pointer (desktop mouse) only.
You cannot keyboard navigate to the headings.
This is because I felt it would be noisy to duplicate the headings with links.
On pages such as typography you'd also get headings and the sub navigation with the same URL.
If you're looking to navigate to a heading in assistive technologies you could already use the overview for headings and headings shortcuts, so it feels like adding these additionally as links is extra noise.
I'm not sure if this is the right decision which is why I'm opening this as a prototype for discussion.
Features
Screenshots
Closes #425