f

alphagov · Feb 7, 2025 · c734459 · c734459
1 parent f6005e3
commit c734459
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/govuk-app-linter.sh b/govuk-app-linter.sh
@@ -1,9 +1,9 @@
 #!/bin/bash
 # set -e
 
-declare -a ENVIRONMENTS=("integration" "staging" "production")
+ENVIRONMENTS=("integration" "staging" "production")
 
-for env in "$ENVIRONMENTS"; do
+for env in "${ENVIRONMENTS[@]}"; do
   array_length=$(yq e ".govukApplications | length - 1" "./charts/app-config/ci/$env-values.yaml")
 
   if [ "$array_length" -le 0 ] ; then
@@ -34,7 +34,8 @@ for env in "$ENVIRONMENTS"; do
   done
 
   if [[ errors -gt 0 ]]; then
-    echo "$errors $env lint errors found";
+    echo "$errors lint errors found in $env values";
+    exit 1
   fi
 
 done