Update to latest cypress #4420
Open
Update to latest cypress #4420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattvague
commented
Oct 28, 2024
Comment on lines
772
to
778
| get("@button").trigger("click", { ctrlKey: true, shiftKey: true, metaKey: true, altKey: true }); | ||
| get("@shift").as("shift").should(beChecked()); | ||
| get("@ctrl").as("ctrl").should(beChecked()); | ||
| get("@meta").as("meta").should(beChecked()); | ||
| get("@alt").as("alt").should(beChecked()); | ||
| get("@cmd").as("cmd").should(beChecked()); | ||
| get("@shift").should(beChecked()); | ||
| get("@ctrl").should(beChecked()); | ||
| get("@meta").should(beChecked()); | ||
| get("@alt").should(beChecked()); | ||
| get("@cmd").should(beChecked()); | ||
| } |
There was a problem hiding this comment.
Not sure why this wasn't causing an issue before (or maybe it was and it was hidden), but in the latest cypress this this throws a max stack depth error (as you would expect it to I think?)
There was a problem hiding this comment.
funny.
I think that's my mistake. I added those in one spot, and maybe copy pasted it without care and it happened to work on the old version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version of Cypress is 7.0.0 which is quite out of date and was running very slowly (at least on my computer). This PR updates to Cypress 13.15.1 which makes the tests run much faster and paves the way for us to also see if we can migrate from e2e specs to component specs which (IMO) are more suited to this case. Happy to help with that as well in a future PR.