Merge pull request #341 from altmp/ALTV-462

ALTV-462 Fix buffer leak in emitClientRaw
altmp · Dec 28, 2024 · d512099 · d512099
2 parents 142e03c + 68f1390
commit d512099
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/shared/helpers/Serialization.cpp b/shared/helpers/Serialization.cpp
@@ -528,7 +528,10 @@ alt::MValueByteArray V8Helpers::V8ToRawBytes(v8::Local<v8::Value> val)
     if(!serializer.WriteValue(ctx, val).To(&result) || !result) return alt::MValueByteArray();
 
     std::pair<uint8_t*, size_t> serialized = serializer.Release();
-    return alt::ICore::Instance().CreateMValueByteArray(serialized.first, serialized.second);
+    auto mvArray = alt::ICore::Instance().CreateMValueByteArray(serialized.first, serialized.second);
+
+    delegate.FreeBufferMemory(serialized.first);
+    return mvArray;
 }
 
 // Converts a MValue byte array to a JS value