Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: moves the favorite star button the left #2535

Closed
wants to merge 1 commit into from
Closed

Conversation

amir20
Copy link
Owner

@amir20 amir20 commented Nov 25, 2023

Screenshot 2023-11-25 at 6 59 39 PM

@amir20 amir20 mentioned this pull request Nov 25, 2023
@uhlhosting
Copy link

Hi, I have tried several ways to enter the docker image, and apply the patch manually, that did not worked for me:

root@pac:/home/pac# docker exec -it df676f508ef7 /bin/sh
OCI runtime exec failed: exec failed: unable to start container process: exec: "/bin/sh": stat /bin/sh: no such file or directory: unknown
root@pac:/home/pac# sudo docker exec -it df676f508ef7 "lsb_release -a"
OCI runtime exec failed: exec failed: unable to start container process: exec: "lsb_release -a": executable file not found in $PATH: unknown
root@pac:/home/pac# sudo docker exec -it df676f508ef7 "uname -a"
OCI runtime exec failed: exec failed: unable to start container process: exec: "uname -a": executable file not found in $PATH: unknown
root@pac:/home/pac# sudo docker exec -it df676f508ef7 "uptime"

upon discussion with a colleague and checking the code, we noticed you use FROM scratch inside docker file at line 51 actually just replacing it with FROM alpine should work in theory.

@amir20
Copy link
Owner Author

amir20 commented Nov 27, 2023

Hi, I have tried several ways to enter the docker image, and apply the patch manually, that did not worked for me:

Huh? Why do you need to do that? Just use amir20:dozzle/pr-2535 as I said in #2522 (comment). The code is compiled. You can't patch it.

@amir20 amir20 closed this Nov 30, 2023
@uhlhosting
Copy link

@amir20 all works as designed, thanks for the quick fix!

@amir20
Copy link
Owner Author

amir20 commented Nov 30, 2023

I am still not too happy with it, so I'll come back to it later. I think this fix breaks other things.

@uhlhosting
Copy link

@amir20 I haven't seen anything broken yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants