Refactor some decimal-related code and tests #7062
Merged
+400
−688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 6 out of 10 changed files in this pull request and generated 3 comments.
Files not reviewed (4)
- arrow-cast/src/cast/decimal.rs: Evaluated as low risk
- arrow/benches/builder.rs: Evaluated as low risk
- arrow/tests/array_cast.rs: Evaluated as low risk
- arrow-data/src/data.rs: Evaluated as low risk
Comments suppressed due to low confidence (1)
arrow-ord/src/sort.rs:1936
- The parameters 'precision' and 'scale' should be consistent with the data type used in 'create_decimal_array'.
precision: u8, scale: i8
…g Decimal32 and Decimal64 support
CurtHagenlocher
force-pushed
the
DecimalRefactor
branch
from
02d01f6 to
0c90b05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of addressing #6661 but does not close it.
Rationale for this change
This change refactors some decimal-related code and tests in preparation for adding Decimal32 and Decimal64 support. It was factored out of #7061 to reduce the code review burden.
What changes are included in this PR?
Refactoring of decimal-related code and tests.
Are there any user-facing changes?
No.