GH-45366: [C++][Parquet] Set is_compressed to false when data page v2 is not compressed #45367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Parquet
Component: C++
awaiting review
raulcd
reviewed
Feb 7, 2025
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
raulcd
reviewed
Feb 7, 2025
There was a problem hiding this comment.
This is a neat improvement. Thanks @mapleFU ! The last change fixed the segmentation fault on Python. I am ok with this PR but will let other experts review / approve. I am just wondering if we don't add specific tests to validate this new behavior
github-actions
bot
added
awaiting changes
wgtmac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?