[CALCITE-6812] Support base64 and unbase64 functions for Hive #4176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzifu666
changed the title
xuzifu666
force-pushed
the
base64_support
branch
from
1425faf to
63bd5b7
Compare
xuzifu666
force-pushed
the
base64_support
branch
from
63bd5b7 to
4b7c684
Compare
|
caicancai
reviewed
Feb 2, 2025
ILuffZhe
reviewed
Feb 2, 2025
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java
Outdated
Show resolved
Hide resolved
ILuffZhe
reviewed
Feb 2, 2025
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java
Outdated
Show resolved
Hide resolved
caicancai
reviewed
Feb 2, 2025
|
@caicancai @ILuffZhe had addressed comments, PTAL when had free time, thanks~ |
xuzifu666
force-pushed
the
base64_support
branch
from
4f78e6f to
a491a5a
Compare
ILuffZhe
approved these changes
Feb 5, 2025
ILuffZhe
added
the
LGTM-will-merge-soon
|
Very thanks for @caicancai @ILuffZhe review~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently calcite not support base64 and unbase64 functions for Hive Library, need to support it.
jira: https://issues.apache.org/jira/browse/CALCITE-6812