[fix](cloud) shorten cache lock held time and add metrics #47472
+123
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when update bvar metrics, we held block lock in the critical context of cache lock, make the later lock held too long and affect other cache logic. we use unsafe method to update the bvar to boost performance. some key metrics of lock and other meaningful metrics are also added for better monitoring cache time costs. Signed-off-by: zhengyu <[email protected]>
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 32396 ms |
TPC-DS: Total hot run time: 192068 ms |
ClickBench: Total hot run time: 30.08 s |
|
TeamCity be ut coverage result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
gavinchou
reviewed
Jan 30, 2025
| @@ -59,6 +59,10 @@ FileBlock::State FileBlock::state() const { | |||
| return _download_state; | |||
| } | |||
|
|
|||
| FileBlock::State FileBlock::state_unsafe() const { | |||
There was a problem hiding this comment.
this only works on x86
gavinchou
reviewed
Jan 30, 2025
Comment on lines
+1063
to
+1064
| DEFINE_mInt64(cache_lock_wait_long_tail_threshold_us, "30000000"); | ||
| DEFINE_mInt64(cache_lock_held_long_tail_threshold_us, "30000000"); |
There was a problem hiding this comment.
30000000 means 30 seconds, it seems too long...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when update bvar metrics, we held block lock in the critical context of cache lock, make the later lock held too long and affect other cache logic. we use unsafe method to update the bvar to boost performance.
some key metrics of lock and other meaningful metrics are also added for better monitoring cache time costs.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)