Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement](brpc) remove client from brpc cache if the underline channel has error #47487

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

yiguolei
Copy link
Contributor

What problem does this PR solve?

If the channel in the stub has error, it should not be reused any more, it should be removed from the cache.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 29, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yiguolei
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32379 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 409ef9b029365c47cfb9edcbaa9859d48bef2644, data reload: false

------ Round 1 ----------------------------------
q1	17767	5686	5464	5464
q2	2055	317	179	179
q3	10519	1287	754	754
q4	10212	981	526	526
q5	7799	2386	2182	2182
q6	193	179	132	132
q7	905	754	609	609
q8	9235	1378	1128	1128
q9	5151	4922	4910	4910
q10	6932	2354	1890	1890
q11	477	270	255	255
q12	341	364	224	224
q13	17765	3705	3075	3075
q14	236	233	209	209
q15	529	494	463	463
q16	637	623	604	604
q17	577	870	329	329
q18	7209	6544	6437	6437
q19	3215	955	520	520
q20	305	310	186	186
q21	2827	2154	1996	1996
q22	362	338	307	307
Total cold run time: 105248 ms
Total hot run time: 32379 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5675	5493	5473	5473
q2	240	329	240	240
q3	2305	2691	2335	2335
q4	1406	1769	1371	1371
q5	4350	4759	4747	4747
q6	175	163	128	128
q7	2072	2019	1850	1850
q8	2634	2876	2718	2718
q9	7348	7233	7348	7233
q10	2978	3321	2714	2714
q11	576	514	494	494
q12	657	745	655	655
q13	3549	3975	3274	3274
q14	282	303	276	276
q15	524	467	472	467
q16	669	681	639	639
q17	1273	1761	1265	1265
q18	7866	7505	7290	7290
q19	792	1085	1119	1085
q20	2022	2058	1897	1897
q21	5842	5122	5041	5041
q22	636	582	571	571
Total cold run time: 53871 ms
Total hot run time: 51763 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192078 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 409ef9b029365c47cfb9edcbaa9859d48bef2644, data reload: false

query1	1336	981	944	944
query2	6188	2064	2031	2031
query3	10998	4472	4345	4345
query4	61187	29061	23223	23223
query5	5495	588	439	439
query6	432	181	172	172
query7	5557	496	309	309
query8	348	252	237	237
query9	8475	2669	2654	2654
query10	468	298	266	266
query11	17669	15095	15698	15095
query12	171	113	112	112
query13	1425	566	405	405
query14	11315	7094	7729	7094
query15	207	203	201	201
query16	7285	586	472	472
query17	1198	770	598	598
query18	1877	429	313	313
query19	212	186	183	183
query20	120	117	114	114
query21	215	120	107	107
query22	4350	4740	4394	4394
query23	34201	33605	33457	33457
query24	5531	2327	2287	2287
query25	462	462	404	404
query26	648	288	159	159
query27	1741	482	331	331
query28	4183	2469	2440	2440
query29	563	549	426	426
query30	215	185	170	170
query31	930	862	821	821
query32	70	58	57	57
query33	500	353	293	293
query34	770	854	503	503
query35	828	877	766	766
query36	989	1061	980	980
query37	131	102	77	77
query38	4264	4385	4268	4268
query39	1531	1490	1426	1426
query40	219	120	107	107
query41	55	53	50	50
query42	119	108	105	105
query43	524	525	490	490
query44	1477	826	846	826
query45	185	184	169	169
query46	887	1063	677	677
query47	1896	1917	1853	1853
query48	409	394	319	319
query49	722	490	399	399
query50	664	678	387	387
query51	4321	4328	4303	4303
query52	105	99	91	91
query53	230	261	193	193
query54	487	498	413	413
query55	84	84	81	81
query56	266	279	253	253
query57	1194	1203	1157	1157
query58	258	243	237	237
query59	3169	3300	3142	3142
query60	275	260	267	260
query61	116	115	115	115
query62	759	725	679	679
query63	242	197	189	189
query64	1396	977	676	676
query65	3244	3162	3146	3146
query66	698	392	316	316
query67	15931	15679	15426	15426
query68	4781	770	538	538
query69	484	291	257	257
query70	1133	1119	1169	1119
query71	404	279	260	260
query72	5410	3802	3918	3802
query73	753	760	355	355
query74	10076	9224	9019	9019
query75	3243	3164	2639	2639
query76	3596	1146	807	807
query77	475	368	269	269
query78	10210	10176	9405	9405
query79	2322	851	607	607
query80	739	524	452	452
query81	520	272	237	237
query82	264	148	121	121
query83	183	171	147	147
query84	294	90	72	72
query85	739	346	297	297
query86	350	318	303	303
query87	4519	4459	4373	4373
query88	3321	2179	2154	2154
query89	393	413	289	289
query90	1552	193	189	189
query91	139	137	111	111
query92	59	59	52	52
query93	1636	894	537	537
query94	613	413	303	303
query95	340	276	260	260
query96	496	613	285	285
query97	2766	2818	2739	2739
query98	218	202	189	189
query99	1304	1379	1259	1259
Total cold run time: 307349 ms
Total hot run time: 192078 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.27 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 409ef9b029365c47cfb9edcbaa9859d48bef2644, data reload: false

query1	0.03	0.02	0.03
query2	0.07	0.03	0.03
query3	0.23	0.06	0.07
query4	1.62	0.10	0.11
query5	0.42	0.44	0.42
query6	1.14	0.66	0.66
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.56	0.49	0.52
query10	0.56	0.56	0.55
query11	0.15	0.11	0.11
query12	0.14	0.11	0.12
query13	0.62	0.60	0.61
query14	2.76	2.72	2.86
query15	0.89	0.84	0.83
query16	0.39	0.39	0.39
query17	1.00	1.06	1.06
query18	0.24	0.20	0.21
query19	1.98	1.83	1.98
query20	0.01	0.01	0.01
query21	15.36	0.89	0.58
query22	0.75	0.88	0.73
query23	15.18	1.47	0.66
query24	2.95	1.43	1.34
query25	0.19	0.10	0.16
query26	0.27	0.14	0.14
query27	0.08	0.05	0.04
query28	14.23	1.00	0.44
query29	12.57	3.94	3.29
query30	0.25	0.09	0.06
query31	2.81	0.61	0.38
query32	3.23	0.56	0.47
query33	2.96	3.02	3.07
query34	16.67	5.19	4.49
query35	4.49	4.49	4.48
query36	0.67	0.49	0.49
query37	0.10	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.03
query40	0.17	0.13	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 106.04 s
Total hot run time: 31.27 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 42.10% (11002/26135)
Line Coverage: 32.36% (92870/286965)
Region Coverage: 31.51% (47621/151111)
Branch Coverage: 27.53% (24097/87524)
Coverage Report: http://coverage.selectdb-in.cc/coverage/409ef9b029365c47cfb9edcbaa9859d48bef2644_409ef9b029365c47cfb9edcbaa9859d48bef2644/report/index.html

Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants