Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade OpenNLP from 2.3.2 to 2.5.3 #14130

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Upgrade OpenNLP from 2.3.2 to 2.5.3 #14130

merged 3 commits into from
Jan 28, 2025

Conversation

msfroh
Copy link
Contributor

@msfroh msfroh commented Jan 9, 2025

Resolves #14029

dweiss
dweiss approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@dweiss dweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also upgrades a major version of slf4j-api as a transitive dependency. Perhaps worth mentioning in changes.txt (which is missing here too)?

@msfroh
Copy link
Contributor Author

msfroh commented Jan 10, 2025 •
edited
Loading

Sure thing! I actually did this upgrade a few weeks ago as part of a skunkworks project to add Apache Arrow as a Lucene data format and hit a Slf4j conflict (which I fixed by upgrading OpenNLP). It's a pretty significant upgrade.

As called out on the linked issue, I'm planning to follow this up with the changes required to use the new UD model.

@msfroh msfroh force-pushed the upgrade_opennlp_2_5 branch from 499d4de to 2ddbb9c Compare January 10, 2025 18:55
@mawiesne
Copy link

FYI: OpenNLP 2.5.3 released yesterday (Jan 10).

See: https://opennlp.apache.org/news/release-253.html

@msfroh
Copy link
Contributor Author

msfroh commented Jan 13, 2025

Thanks, @mawiesne! I just updated this PR to pick up 2.5.3 instead.

@msfroh msfroh changed the title Upgrade OpenNLP from 2.3.2 to 2.5.2 Upgrade OpenNLP from 2.3.2 to 2.5.3 Jan 13, 2025
@dweiss
Copy link
Contributor

dweiss commented Jan 15, 2025

LGTM. I think this should go on main and branch_10x?

@mawiesne
Copy link

@msfroh Anything open or preventing a merge of this PR to main/10.x ?

@msfroh
Copy link
Contributor Author

msfroh commented Jan 28, 2025

@msfroh Anything open or preventing a merge of this PR to main/10.x ?

I don't think so. It just needs to be merged by a Lucene committer. (I don't have permission.)

@dweiss -- are you able to help out? Thanks!

@msokolov
Copy link
Contributor

I can merge

@msokolov msokolov merged commit a7b7f0d into apache:main Jan 28, 2025
5 checks passed
msfroh added a commit to msfroh/lucene that referenced this pull request Jan 29, 2025
@msfroh
Upgrade OpenNLP from 2.3.2 to 2.5.3 (apache#14130)
f2521ce
msokolov pushed a commit that referenced this pull request Jan 29, 2025
@msfroh
Upgrade opennlp and codec 10x (#14177)
2795026 
* Upgrade OpenNLP from 2.3.2 to 2.5.3 (#14130)

* Upgrade commons-codec from 1.13.0 to 1.17.2 (#14129)
@mawiesne
Copy link

I can merge

Thx @msokolov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mawiesne mawiesne mawiesne approved these changes

@rzo1 rzo1 rzo1 approved these changes

@tteofili tteofili tteofili approved these changes

@dweiss dweiss dweiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to OpenNLP 2.5.x
6 participants
@msfroh @mawiesne @dweiss @msokolov @tteofili @rzo1