[SPARK-51011][CORE] Add logging for whether a task is going to be interrupted when killed #49699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
|
cc: @JoshRosen, but let me know if you do not want to review this. Also, I don't plan on backporting this, but reviewers, please let me know if you think it's a good idea. |
neilramaswamy
changed the title
JoshRosen
approved these changes
Jan 28, 2025
HyukjinKwon
approved these changes
Feb 3, 2025
|
Merged to master and branch-4.0. |
HyukjinKwon
added a commit
that referenced
this pull request
Feb 3, 2025
…errupted when killed We now log the value of `interruptThread` when a `TaskRunner`'s `kill` method is killed. This should help with debugging when potential zombie Spark tasks do not seem to be exiting. Today, it's tricky to debug why a task is not exiting (and thus, why executors might be getting lost) without knowing for sure if it was issued a Java interrupt. No. Ran `org.apache.spark.executor.ExecutorSuite` and verified the log looked as expected. No. Closes #49699 from neilramaswamy/spark-51011. Lead-authored-by: Neil Ramaswamy <[email protected]> Co-authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit f03f45e) Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We now log the value of
interruptThreadwhen aTaskRunner'skillmethod is killed. This should help with debugging when potential zombie Spark tasks do not seem to be exiting.Why are the changes needed?
Today, it's tricky to debug why a task is not exiting (and thus, why executors might be getting lost) without knowing for sure if it was issued a Java interrupt.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Ran
org.apache.spark.executor.ExecutorSuiteand verified the log looked as expected.Was this patch authored or co-authored using generative AI tooling?
No.