[SPARK-50843][ML][PYTHON][CONNECT] Support return a new model from existing one #49709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
changed the title
zhengruifeng
changed the title
zhengruifeng
commented
Jan 28, 2025
| @@ -2290,10 +2291,15 @@ def featureImportances(self) -> Vector: | |||
| """ | |||
| return self._call_java("featureImportances") | |||
|
|
|||
| @property | |||
| @cached_property | |||
There was a problem hiding this comment.
cache the result to avoid re-generating and re-caching the submodels (the trees) in the server side.
zhengruifeng
added a commit
that referenced
this pull request
Feb 2, 2025
…isting one ### What changes were proposed in this pull request? Support return a new model from existing one, e.g. 1, `RandomForestClassificationModel.trees` -> get underlying decision tree models; 2, `DistributedLDAModel.toLocal` -> get a `LocalLDAModel` ### Why are the changes needed? feature parity ### Does this PR introduce _any_ user-facing change? yes ### How was this patch tested? added tests ### Was this patch authored or co-authored using generative AI tooling? no Closes #49709 from zhengruifeng/ml_connect_model. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]> (cherry picked from commit ba18f50) Signed-off-by: Ruifeng Zheng <[email protected]>
|
merged to master/4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support return a new model from existing one, e.g.
1,
RandomForestClassificationModel.trees-> get underlying decision tree models;2,
DistributedLDAModel.toLocal-> get aLocalLDAModelWhy are the changes needed?
feature parity
Does this PR introduce any user-facing change?
yes
How was this patch tested?
added tests
Was this patch authored or co-authored using generative AI tooling?
no