Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-51015][ML][PYTHON][CONNECT] Support RFormulaModel.toString on Connect #49745

Closed
wants to merge 1 commit into from

Conversation

wbo4958
Copy link
Contributor

@wbo4958 wbo4958 commented Jan 31, 2025

What changes were proposed in this pull request?

This PR adds support toString for RFormulaModel on ml Connect.

Why are the changes needed?

Feature parity

Does this PR introduce any user-facing change?

Yes

How was this patch tested?

CI passes

Was this patch authored or co-authored using generative AI tooling?

No

@wbo4958
Copy link
Contributor Author

wbo4958 commented Jan 31, 2025

Hi @zhengruifeng , Please take a look at this PR. Thx

Copy link
Contributor

@zhengruifeng zhengruifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

zhengruifeng pushed a commit that referenced this pull request Feb 2, 2025
…Connect

### What changes were proposed in this pull request?

This PR adds support toString for RFormulaModel on ml Connect.

### Why are the changes needed?

Feature parity

### Does this PR introduce _any_ user-facing change?
Yes

### How was this patch tested?
CI passes

### Was this patch authored or co-authored using generative AI tooling?
No

Closes #49745 from wbo4958/rf.tostring.

Authored-by: Bobby Wang <[email protected]>
Signed-off-by: Ruifeng Zheng <[email protected]>
(cherry picked from commit f2d65ee)
Signed-off-by: Ruifeng Zheng <[email protected]>
@zhengruifeng
Copy link
Contributor

merged to master/4.0

@wbo4958 wbo4958 deleted the rf.tostring branch February 2, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants