-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Discovery and Generation Framework #2198
Conversation
Thanks for this great rewrite generation framework @Jaybit0. When rebasing to main in order to play around with this patch, I'm getting merge conflicts though which is no fun with 280+ commits. Could you help rebase this PR or create a new one with all commits squashed to one? In preparation of merging this PR, please also remove the wildcard imports. Thanks. |
Okay, I will try to rebase and reopen the PR again. Maybe something went wrong with my previous rebase |
Thank you very much. |
This PR introduces a rewrite discovery and generation framework that supports offline systematic, random, and data-driven search strategies. Most of the changes do not affect the runtime of SystemDS. In
DMLScript
, I introduce an interceptor function that the framework requires for rule validation and data retrieval. With the flag-applyGeneratedRewrites
, the generated rewrites inGeneratedRewriteClass
are applied at runtime. To run the framework, I have provided the classRewriterFramework
which can be executed on its own.I introduce a file called
expressions.db
that stores all extracted expressions for the data-driven search which causes the license check to fail.Sorry for the large PR
@mboehm7