Fix cask token error in brew api-readall-test
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` $ brew api-readall-test Generating formulae API ... and mocking formula API loader. Read core formulae and saw no failures! Generating cask API ...Warning: Cask font-rounded-mplus was renamed to font-rounded-m+. and mocking cask API loader. Read core casks and saw 1 failure! Readall Failures: Casks ----------------------- >> font-rounded-mplus : key not found: "font-rounded-mplus" /usr/local/Homebrew/Library/Homebrew/cask/cask_loader.rb:318:in `fetch' ``` The problem was that `font-rounded-mplus` got renamed to `font-rounded-m+` and we were getting the cask tokens from the file names instead of the cask definitions directly. I'm not entirely sure why the cask token name from the core cask tap are wrong here but changing the order and basing it on the cask that was loaded seems to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that
font-rounded-mplusgot renamed tofont-rounded-m+and we were getting the cask tokens from the file names instead of the cask definitions directly. I'm not entirely sure why the cask token name from the core cask tap are wrong here but changing the order and basing it on the cask that was loaded seems to work.