Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untangle external reader code #776

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Untangle external reader code #776

wants to merge 2 commits into from
+341 −385

Commits on Nov 15, 2024

  1. Untangle external reader code 

    - move the following classes into package externalreader:
  - ExternalModuleResolver
  - ExternalResourceResolver
  - MessageTransportModuleResolver (renamed to ExternalModuleResolverImpl, made package-private)
  - MessageTransportResourceResolver (renamed to ExternalResourceResolverImpl, made package-private)
- replace interface ExternalModuleResolver.Spec with record ExternalModuleReaderSpec
- replace interface ExternalResourceResolver.Spec with record ExternalResourceReaderSpec
- translate between messaging.ResourceReaderSpec and ExternalResourceReaderSpec (eliminates dependency from messaging on higher layer)
- translate between messaging.ResourceResolverSpec and ExternalResourceResolverSpec (eliminates dependency from messaging on higher layer)
- add ServerMessages.ExternalReader and translate between this message component and the PklEvaluatorSettings.ExternalReader API
- add ServerMessages.Proxy and translate between this message component and the PklEvaluatorSettings.Proxy API
- change type of CreateEvaluatorRequest.allowedModules/allowedResources from List<Pattern>? to List<String>?
  - removes a lot of code
  - should not need to create a Pattern object to send a message
- remove public method evaluatorSettings.PklEvaluatorSettings.Proxy.create()
  - only seems useful internally, inlined
    @translatenix
    translatenix committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    54984d5 View commit details
    Browse the repository at this point in the history

  2. Strip "External" from class names in package externalreader 

    - class names were too long/repetitive
- package name provides sufficient context
    @translatenix
    translatenix committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    1389907 View commit details
    Browse the repository at this point in the history