fix: Add invocation startTime and endTime to SARIF output #8255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes aquasecurity#3226 Add invocation `startTimeUtc` and `endTimeUtc` properties to SARIF output report. * **pkg/report/sarif.go** - Import `time` package. - Add `StartTime` and `EndTime` fields to `SarifWriter` struct. - Set `startTimeUtc` and `endTimeUtc` properties in the `Write` method. * **pkg/report/writer.go** - Import `time` package. - Add `StartTime` and `EndTime` fields to `SarifWriter` initialization in the `Write` method. * **pkg/report/sarif_test.go** - Add test `TestSarifWriter_Write_WithInvocationTimes` to verify `startTimeUtc` and `endTimeUtc` properties in SARIF report. - Ensure test covers various scenarios for `startTimeUtc` and `endTimeUtc`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/aquasecurity/trivy/issues/3226?shareId=XXXX-XXXX-XXXX-XXXX).
…in Options struct - to fix integration tests
|
Anupam Mediratta seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Hi @anupamme, thanks for your contribution. It looks like you added a commit authored by another email address, which leads to CLA failure. Can you please re-commit it with the correct address or sign the CLA with the address as well?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3226
Add invocation
startTimeUtcandendTimeUtcproperties to SARIF output report.pkg/report/sarif.go
timepackage.StartTimeandEndTimefields toSarifWriterstruct.startTimeUtcandendTimeUtcproperties in theWritemethod.pkg/report/writer.go
timepackage.StartTimeandEndTimefields toSarifWriterinitialization in theWritemethod.pkg/report/sarif_test.go
TestSarifWriter_Write_WithInvocationTimesto verifystartTimeUtcandendTimeUtcproperties in SARIF report.startTimeUtcandendTimeUtc.For more details, open the Copilot Workspace session.