-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: New kube applier for server side diff dry run with refactoring (#21488) #21749
Draft
andrii-korotkov-verkada
wants to merge
10
commits into
argoproj:master
Choose a base branch
from
andrii-korotkov-verkada:21488-new-kube-applier-for-server-side-diff-dry-run-with-refactoring
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+59
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rgoproj#21488) Fixes: argoproj#21488 Use the new kube applier from gitops engine, which avoid the error arising from concatenating kube command stderr to stdout. Needs to be cherry-picked to v2.14. Signed-off-by: Andrii Korotkov <[email protected]>
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Signed-off-by: Andrii Korotkov <[email protected]>
Signed-off-by: Andrii Korotkov <[email protected]>
Signed-off-by: Andrii Korotkov <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21749 +/- ##
==========================================
- Coverage 55.63% 55.63% -0.01%
==========================================
Files 339 339
Lines 56813 56827 +14
==========================================
+ Hits 31608 31615 +7
- Misses 22553 22559 +6
- Partials 2652 2653 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andrii Korotkov <[email protected]>
Signed-off-by: Andrii Korotkov <[email protected]>
Signed-off-by: Andrii Korotkov <[email protected]>
Signed-off-by: Andrii Korotkov <[email protected]>
Signed-off-by: Andrii Korotkov <[email protected]>
…f-dry-run-with-refactoring Signed-off-by: Andrii Korotkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #21488
Use the new kube applier from gitops engine, which avoid the error arising from concatenating kube command stderr to stdout.
Needs to be cherry-picked to v2.14, but need a manual PR due to referencing v3 vs v2.
Checklist: