fix(cli): core redis compression based on argocd-cmd-params-cm

[NetanelK]

Fixes #15912
Fixes #15077

This PR adds optional Redis compression from argocd-cmd-params-cm, which defaults to gzip, into headless mode appstatecache.

Fix should be cherry-picked into v2.11, v2.12 and v2.13

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[codecov]

Codecov Report

Attention: Patch coverage is 37.03704% with 17 lines in your changes missing coverage. Please review.

Project coverage is 55.61%. Comparing base (d183d9c) to head (0a20804).
Report is 3 commits behind head on master.

Files with missing lines	Patch %	Lines
cmd/argocd/commands/headless/headless.go	0.00%	10 Missing ⚠️
cmd/argocd/commands/admin/dashboard.go	0.00%	4 Missing ⚠️
common/common.go	76.92%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #21840      +/-   ##
==========================================
+ Coverage   55.58%   55.61%   +0.02%     
==========================================
  Files         339      339              
  Lines       56874    56891      +17     
==========================================
+ Hits        31616    31638      +22     
+ Misses      22609    22603       -6     
- Partials     2649     2650       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nitishfy]

Hi, thanks for raising this PR. We recently introduced the redis-compress flag as a global flag in #21786 which I believe solves the problem for both the issues you specified above. Furthermore, what you're doing in this PR is getting the flag value from the controller flag and setting it in the headless function. Instead of all this, it is better to introduce the redis-compress flag as a global flag (see this comment) than only removing this flag from specific subcommands.

[NetanelK]

Hi, thanks for raising this PR. We recently introduced the redis-compress flag as a global flag in #21786 which I believe solves the problem for both the issues you specified above. Furthermore, what you're doing in this PR is getting the flag value from the controller flag and setting it in the headless function. Instead of all this, it is better to introduce the redis-compress flag as a global flag (see this comment) than only removing this flag from specific subcommands.

Thanks for adding that feature, I just want to verify, both redis-compress flag and redis.compression values should always match, am I right?

[nitishfy]

@NetanelK exactly. The compression on the controller should match with the CLI. If it doesn't, the cache key will be missing.

[NetanelK]

@NetanelK exactly. The compression on the controller should match with the CLI. If it doesn't, the cache key will be missing.

Great to know, although IMO it's easier to fetch the redis.compression value as they always should match.

Anyhow, will #21786 be patched into older versions v2.11-13?

[nitishfy]

Great to know, although IMO it's easier to fetch the redis.compression value as they always should match.

The controller is already doing the fetching part. No need to do the same for CLI.

Anyhow, will #21786 be patched into older versions v2.11-13?

Tagging @ishitasequeira / @crenshaw-dev for this answer.