Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DIA-1062): persist discovered artwork IDs sent to infinite discovery endpoint #11421

Merged
merged 6 commits into from
Jan 23, 2025
Merged

feat(DIA-1062): persist discovered artwork IDs sent to infinite discovery endpoint #11421

merged 6 commits into from
Jan 23, 2025

Conversation

iskounen
Copy link
Contributor

@iskounen iskounen commented Jan 21, 2025 •
edited
Loading

This PR persists a list of artworks that have been received by Infinite Discovery so that those same artworks don't appear in Infinite Discovery again.

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • Persist a list of artworks that have been displayed in Infinite Discovery

Need help with something? Have a look at our docs, or get in touch with us.

@iskounen iskounen self-assigned this Jan 21, 2025
@iskounen iskounen marked this pull request as draft January 21, 2025 19:04
damassi
damassi previously approved these changes Jan 23, 2025
View reviewed changes
@iskounen iskounen force-pushed the iskounen/feat/persist-infinite-discovery-artwork-ids branch from bebcfc1 to 8d906c7 Compare January 23, 2025 14:14
@iskounen iskounen changed the title feat: persist discovered artwork IDs sent to infinite discovery endpoint feat(DIA-1062): persist discovered artwork IDs sent to infinite discovery endpoint Jan 23, 2025
@iskounen iskounen marked this pull request as ready for review January 23, 2025 15:20
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Jan 23, 2025 •
edited
Loading

This PR contains the following changes:

  • Dev changes (Persist a list of artworks that have been displayed in Infinite Discovery - iskounen)

Generated by 🚫 dangerJS against 1ebafad

damassi
damassi approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@damassi damassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@iskounen iskounen merged commit edd9f1e into main Jan 23, 2025
7 checks passed
@iskounen iskounen deleted the iskounen/feat/persist-infinite-discovery-artwork-ids branch January 23, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damassi damassi damassi approved these changes

Assignees

@iskounen iskounen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iskounen @ArtsyOpenSource @damassi